sunank200 opened a new pull request, #40084:
URL: https://github.com/apache/airflow/pull/40084
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
**Why**
For some operators such as `DateTimeSensorAsync` , `TimeDeltaSensorAsync`
and `TimeSensorAsync` it would be better if we could terminate the task without
needing a worker.
**What**
Introduce `BaseTaskEndEvent` to end the task without resuming on the worker.
Triggers have two options: they can either send execution back to the task
or end the task instance directly. If the trigger ends the task instance, the
`method_name` should be None. Otherwise, provide the `method_name` to be used
when resuming the execution in the task.
Previously, we only paid attention to failure requests in
`_execute_task_callbacks`. Now, we also execute any given callback type
directly. In this scenario, the callback is submitted remotely, so we assume
there's no need to change the state; we simply run the callback.
> **Note**: Exiting from the trigger works only when listeners are not
integrated for the deferrable operator. To use this feature, unregister the
listeners, and set end_from_trigger=True on the given operator.
Introduce `end_from_trigger` in each Async operator which end the task
directly from the triggerer without going into the worker. For example:
```
with DAG(
"async_dag",
) as dag:
async_date_time_sensor = DateTimeSensorAsync(
task_id="async_date_time_sensor",
target_time="""{{ macros.datetime.utcnow() +
macros.timedelta(minutes=1) }}""",
end_from_trigger=True,
)
async_time_delta = TimeDeltaSensorAsync(
task_id="async_time_delta",
delta=datetime.timedelta(minutes=1),
end_from_trigger=False,
)
async_time_sensor = TimeSensorAsync(
task_id="async_time_sensor",
timeout=1,
soft_fail=True,
target_time=(datetime.datetime.now(tz=dt.timezone.utc) +
datetime.timedelta(minutes=1)).time(),
end_from_trigger=True,
)
```
By default `end_from_trigger` is `False`.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
