potiuk commented on PR #40916:
URL: https://github.com/apache/airflow/pull/40916#issuecomment-2246185210
Allright @jscheffl @dstandish @vincbeck (and @mhenc) - it looks like we
have it.
Once i have some one more pair of eyes I think this one concludes the main
part (and I think we made it before 2.10 cut-off @ephraimbuddy ?).
What nicely work there (at least manually checks):
a) airflow in breeze works out-of-the-box with any combination of:
* `--db-isolation-mode`
* `--standalone-dag-processor`
* Local and Celery Executor (Local Executor mostly because I wanted to
test if it works when run K8S Executor that intenrnally uses LocalExecutor
b) Authentication works nicely using separate internal_api_secret_key.
c) Performance does not look bad actually at least on local machine - but I
am sure it can be optimized further.
d) we do not use https:// - but I think this should be described in the
documentation that SSL terminatinb proxies shoudl be used in front of
internal-api to add SSL (usual practice). We might want to give a big WARNING
if someone uses HTTP:// in the client
What we will need more is:
a) special tests for isolatin mode
b) documentation (stressing experimental status)
But those can be even added after the cut-off for 2.10 branch and
cherry-picked potentially.
I think particularly the Dag File Processor was an interesting one in lights
of AIP-72 - I think it can be much more easily mapped almost 1-1 to whatever
AIP-72 brings. And nice thing about it that we can tell adventorous users to
use the internal API and report any issues they encounter with lack of DB
access on the side of worker and parser long before AIP-72 will be out)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
