[ 
https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925123#comment-16925123
 ] 

ASF GitHub Bot commented on AIRFLOW-5376:
-----------------------------------------

potiuk commented on pull request #6054: [AIRFLOW-5376] Add coverage package 
back to devel extras
URL: https://github.com/apache/airflow/pull/6054
 
 
   OK. I know what happened exactly. It was my mistake. 
   
   When I moved code coverage reporting with codecov to outside script (where 
it should be), I removed codecov as dependency (#5732). It also had transitive 
dependency to coverage package, so when the images got refreshed some time 
later, the coverage dependency was gone and no coverage information was 
reported any more.
   
   Adding coverage package should fix it hopefully.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Codecov does not work for new CI  :(
> ------------------------------------
>
>                 Key: AIRFLOW-5376
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5376
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to