sunank200 commented on code in PR #40084:
URL: https://github.com/apache/airflow/pull/40084#discussion_r1689255921
##########
tests/sensors/test_time_sensor.py:
##########
@@ -63,7 +63,6 @@ def test_task_is_deferred(self):
assert isinstance(exc_info.value.trigger, DateTimeTrigger)
assert exc_info.value.trigger.moment == timezone.datetime(2020, 7, 7,
10)
- assert exc_info.value.method_name == "execute_complete"
Review Comment:
I mean if you look at
https://github.com/apache/airflow/blob/4bba0d1f4a6ff7f34c786e4a56ad1934cb923e66/airflow/sensors/time_sensor.py#L78-L81
we are always passing `execute_complete` as `method_name` regardless of
`end_from_trigger=True` or `end_from_trigger=False`. We implemented this to
facilitate the user's ability to end the task by the worker for this sensor.
That is not required for `end_from_trigger=True`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
