eladkal commented on code in PR #40976:
URL: https://github.com/apache/airflow/pull/40976#discussion_r1689330458


##########
airflow/providers/amazon/aws/hooks/step_function.py:
##########
@@ -51,10 +53,26 @@ def start_execution(
             - :external+boto3:py:meth:`SFN.Client.start_execution`
 
         :param state_machine_arn: AWS Step Function State Machine ARN.
+        :param is_redrive_execution: Restarts unsuccessful executions of 
Standard workflows that did not
+            complete successfully in the last 14 days.
         :param name: The name of the execution.
         :param state_machine_input: JSON data input to pass to the State 
Machine.
         :return: Execution ARN.
         """
+        if is_redrive_execution:
+            if not name:
+                raise AirflowException(
+                    "Execution name is required to start RedriveExecution for 
%s.", state_machine_arn
+                )

Review Comment:
   I think this should be `AirflowFailException` because if name isn't provided 
there is no value in allowing retry for the task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to