JDarDagran commented on PR #40972: URL: https://github.com/apache/airflow/pull/40972#issuecomment-2247330013
> Quick question, if the default behaviour changed and all Facets in v2 have the `slots=True` why not change all the Airflow facets to mimic that and not only the ones that go to DAG events and undergo pickling. Is that impacting the performance a lot? Is there any other point [here](https://www.attrs.org/en/stable/glossary.html#term-slotted-classes) that we are worried about? For the sake of simplicity and to avoid mistakes i think it would be good to keep it consistent. If not, let's at least leave a comment / docstring somewhere in the code about why sometimes it's False and sometimes it's True. I agree, for the sake of simplicity it'd be better to have all facets set slots to True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
