coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized 
DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-529294988
 
 
   > * Do we want to let users use old versions of MySQL (and Mariadb that 
doesn't support JSON with sqlalchemy) or add a note and tell them that if you 
want to use serialisation you would need to use newer version of DB or a DB 
(Postgres) that supports JSON columns. Or else just keep 
`store_serialised_dags=False`. If we want to support old versions or DB that 
don't support JSON columns, that we will have to handle those exceptions and 
store the serialised DAG (python dicts) as string and use json.loads and 
json.dump.
   
   I think it makes sense to deprecate old versions of MySQL that don't support 
JSON (I guess it is MySQL 5.7), unless there are many affected customers. I 
think deprecating old versions is reasonable and it is important to keep code 
less redundant.
   
   > * JSON vs JSONB? - Opinions ??
   
   We are periodically updating serialized DAGs in DB. Will using JSONB makes 
it more efficient?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to