[
https://issues.apache.org/jira/browse/AIRFLOW-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925390#comment-16925390
]
ASF GitHub Bot commented on AIRFLOW-5441:
-----------------------------------------
milton0825 commented on pull request #6061: [AIRFLOW-5441] Ownership of
package*.json file group write is fixed
URL: https://github.com/apache/airflow/pull/6061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When you force pull images with Breeze it rebuilds npm unnecessarily
> --------------------------------------------------------------------
>
> Key: AIRFLOW-5441
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5441
> Project: Apache Airflow
> Issue Type: Bug
> Components: ci
> Affects Versions: 2.0.0, 1.10.6
> Reporter: Jarek Potiuk
> Priority: Major
>
> When you use Breeze and you specify "--force-pull" flag, the latest image
> from DockerHub is pulled before you attempt to rebuild the image. Currently
> in breeze we used an optimised version of "fix-permission" script that only
> fixes permissions of several files in the context (the workaround for
> different (group write) umask setting in DockerHub). However we did not have
> package.json and package-lock.json on the list so those files were always
> seen as "changed" and npm was reinstalled for the first time (and only the
> first time) when the image was force pulled.
>
> After fixing this, the of --force-pull breeze commands will be much faster -
> skipping the whole npm package reinstallation. Depending on your network
> speed, this might be between 20 seconds to several minutes as npm ci command
> wipes out everything and downloads a lot of packages.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
