Lee-W commented on code in PR #41097:
URL: https://github.com/apache/airflow/pull/41097#discussion_r1696534564
##########
airflow/models/dag.py:
##########
@@ -3318,12 +3317,12 @@ def bulk_write_to_db(
curr_outlet_references = curr_orm_dag and
curr_orm_dag.task_outlet_dataset_references
for task in dag.tasks:
dataset_outlets: list[Dataset] = []
- dataset_alias_outlets: list[DatasetAlias] = []
+ dataset_alias_outlets: set[DatasetAlias] = set()
for outlet in task.outlets:
if isinstance(outlet, Dataset):
dataset_outlets.append(outlet)
elif isinstance(outlet, DatasetAlias):
- dataset_alias_outlets.append(outlet)
+ dataset_alias_outlets.add(outlet)
Review Comment:
According to
https://github.com/apache/airflow/blob/a7b0dc25c0201e3e69726aa6033102128d8d9046/airflow/models/dag.py#L3300,
it seems we want to preserve the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
