phi-friday commented on code in PR #41035:
URL: https://github.com/apache/airflow/pull/41035#discussion_r1696557826
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -472,7 +472,7 @@ def _change_state(
if self.kube_config.delete_worker_pods:
if state != TaskInstanceState.FAILED or
self.kube_config.delete_worker_pods_on_failure:
self.kube_scheduler.delete_pod(pod_name=pod_name,
namespace=namespace)
- self.log.info("Deleted pod: %s in namespace %s", key,
namespace)
+ self.log.info("Deleted pod associated with the TI %s. Pod
name: %s. Namespace: %s", key, pod_name, namespace)
Review Comment:
Since we enabled `G` of the `ruff` rules, we should not use f-string in the
logs.
see more:
1. https://docs.astral.sh/ruff/rules/logging-f-string/
2.
https://github.com/apache/airflow/blob/a7b0dc25c0201e3e69726aa6033102128d8d9046/pyproject.toml#L267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
