yuqian90 opened a new pull request #6064: [AIRFLOW-5444] Fix action_logging so 
that request.form for POST is logged
URL: https://github.com/apache/airflow/pull/6064
 
 
   - Log request.form when request.method is POST
   - Add a test for action_logging
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues
     - https://issues.apache.org/jira/browse/AIRFLOW-5444
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   When user performs actions such as "clear", "success" or "failed" on the 
WebUI, important parameters such as dag_id, task_id and execution_date are not 
logged by action_logging because the values are in request.form rather than 
request.args. This PR fixes the issue.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Added tests.www.test_views:TestDecorators to check for the scenario where 
request.method is GET and POST.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to