BTeclaw opened a new pull request, #41150:
URL: https://github.com/apache/airflow/pull/41150

   This PR is a resolution to the given issue #39622. The main bug here was 
that the hook parameters were not properly given to the SnowflakeSqlAPIHook and 
then they were not properly assigned. The query execution method of the hook 
statically assigned configuration from Airflow connection. In this PR it is 
changed so that:
   1. hook_params from SnowflakeSqlApiOperator object is passed into the hook 
object through unpacking the variable.
   2. In SnowflakeSqlApiHook, for each of the parameter (database, role, 
schema, warehouse) there is a check performed for whether they were provided in 
the parameters (in their parent class SnowflakeHook, they are initialized to 
None, hence the if self.database|schema|role|warehouse) and if not, they are 
taken from connection definition.
   
   If merged:
   closes: #39622 
   
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to