lh5844 commented on code in PR #41144:
URL: https://github.com/apache/airflow/pull/41144#discussion_r1698786155


##########
airflow/www/views.py:
##########
@@ -4375,6 +4377,18 @@ def process_form(self, form, is_created):
                     # value isn't an empty string.
                     if value != "":
                         extra[field_name] = value
+                    field = form._fields.get(key)
+                    # Check if the field is a BS3TextFieldWidget
+                    if isinstance(field.widget, BS3TextFieldWidget):
+                        value = form.data.get(key, "")
+                        if isinstance(value, str):
+                            value = value.strip()
+                            if value:

Review Comment:
   Yes, it does warn users even if the field data has not been deleted. I 
couldn't find how to process the form when the 'Save' button is clicked and I 
could only find how to process it after the button is clicked in the codebase. 
If that's the case, would it be better to go with the general warning and get 
rid of this? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to