dondaum commented on code in PR #41017:
URL: https://github.com/apache/airflow/pull/41017#discussion_r1698977165


##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2161,6 +2161,32 @@ paths:
         "404":
           $ref: "#/components/responses/NotFound"
 
+  /dagStats:
+    get:
+      summary: List Dag statistics
+      x-openapi-router-controller: 
airflow.api_connexion.endpoints.dag_stats_endpoint
+      operationId: get_dag_stats
+      tags: [DagStats]
+      parameters:
+        - name: dag_ids
+          in: query
+          schema:
+            type: string
+          required: true
+          description: |
+            One or more DAG IDs separated by commas to filter relevant Dags.

Review Comment:
   Thanks for the feedback! Of course I can set it to optional. But in my 
opinion we then also need to handle the `limit` and `offset` parameters to 
reduce the potentially large query result set when you have many different DAGs 
and DAG runs. 
   
   The current implementation returns the statistics of all selected DAGs 
through the request_form. Thus it is implicitly limited 
[here](https://github.com/apache/airflow/blob/92c8697f20d97b5bd1eae2142412d18bc972906d/airflow/www/views.py#L1229).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to