phi-friday commented on PR #41039: URL: https://github.com/apache/airflow/pull/41039#issuecomment-2266374319
> LGTM overall - had some minor comments in the code plus a couple of questions: > > 1. Did you check that it works for both `PythonVirtualenvOperator` and `ExternalPythonOperator`? (both inherit from `_BasePythonVirtualenvOperator`) > 2. Is there a way to test both operators above with this feature as part of the tests in `tests/operators/test_python.py`? > > Also ,it would be great to add a newsfragment, so other people would be aware of this feature. I moved the task code from `TestPythonVirtualenvOperator` to `BaseTestPythonVirtualenvOperator`. For `BranchMixIn`, the return value is fixed to `list[str(task_id)]`, so I treated it as a special case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
