Grzyblon commented on issue #28737:
URL: https://github.com/apache/airflow/issues/28737#issuecomment-2269755409

   @bbovenzi  I’ve prepared a few proposals based on your comments.
   
   > But maybe we should add those icons to the run_type filters.
   
   It was not so trivial as I thought it'll be. Here are results.
   
![DAG_run_types_in_filter](https://github.com/user-attachments/assets/af6755cc-430d-45d0-b8cf-b7fadf7c13f8)
   I’ve also added rendering StatusWithNotes next to a “Contains a note” text 
with the same status color as task instance/ DAG run tooltip originates from.
   
![DAG_run_typeicon_in_tooltip_airflow](https://github.com/user-attachments/assets/14bf6f61-74dd-42e6-9189-d1b7c520761d)
   
   > Just an InfoTooltip component is fine I think.
   
   I’ve also made grid legend using InfoTooltip component placed over Grid 
component. This definitely needs some more tweaks.
   
![DAG_run_types_in_tooltip_airflow](https://github.com/user-attachments/assets/75103e77-55f9-4f1c-bd8e-3b79da7ff82e)
   
   In my opinion adding icons to run type options in filter plus rendering 
StatusWithNotes component in InstanceTooltip and DagRunTooltip should be 
sufficient. That way user will be getting familiar with the graphics gradually 
as they use these features. In that case adding InfoTooltip with whole legend 
seems redundant.
   
   Is that looks good?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to