mjohansenwork commented on PR #41141: URL: https://github.com/apache/airflow/pull/41141#issuecomment-2269910596
> > That isn't the desired behavior, though, right? [The docs](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/utils/state/index.html#airflow.utils.state.DagRunState) list states like `running` and `queued`, which shouldn't cause the `ExternalTaskSensor` to fail _or_ succeed, right? > > Right, it is not desired. Since `ExternalTaskSensor` is the only place calling `WorkflowTrigger`, I think we are good to update the logic `WorkflowTrigger.run`. I went ahead and deleted the early success branch in `WorkflowTrigger.run` failed states logic. I also updated the tests. One concern I have is if the success states aren't specified, it might end up in an infinite loop, but I'm pretty sure the success states are provided by default by the upstream sensor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
