joaopamaral commented on PR #40703:
URL: https://github.com/apache/airflow/pull/40703#issuecomment-2270038205
Hey @shahar1, I've included the docs and I've dug a little more about the
query count test and basic the difference is during the `_sync_perm_for_dag`:
```
Recorded query locations:
dagbag.py:_sync_perm_for_dag:748 >
override.py:sync_perm_for_dag:1111 > override.py:create_permission:1848 >
override.py:get_permission:1819 > override.py:get_action:1688: 15
dagbag.py:_sync_perm_for_dag:748 >
override.py:sync_perm_for_dag:1111 > override.py:create_permission:1848 >
override.py:get_permission:1820 > override.py:get_resource:1749: 15
dagbag.py:_serialize_dag_capturing_errors:692 >
dagbag.py:_sync_perm_for_dag:748 > override.py:sync_perm_for_dag:1111 >
override.py:create_permission:1848 > override.py:get_permission:1823: 10
E AssertionError: The expected number of db queries is 94 with
extra margin: 10. The current number is 154.
E Recorded query locations:
E dagbag.py:_sync_perm_for_dag:748 >
override.py:sync_perm_for_dag:1123 > override.py:create_permission:1890 >
override.py:get_permission:1861 > override.py:get_action:1730: 35
E dagbag.py:_sync_perm_for_dag:748 >
override.py:sync_perm_for_dag:1123 > override.py:create_permission:1890 >
override.py:get_permission:1862 > override.py:get_resource:1791: 35
E dagbag.py:_serialize_dag_capturing_errors:692 >
dagbag.py:_sync_perm_for_dag:748 > override.py:sync_perm_for_dag:1123 >
override.py:create_permission:1890 > override.py:get_permission:1865: 30
```
As we included more permissions at the DAG level, we expect an increase in
this number:
https://github.com/apache/airflow/blob/27ba034302c1109f721b667326fb14963a768f1d/airflow/providers/fab/auth_manager/security_manager/override.py#L1120-L1123
Do you think we can increase the query count for this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
