uranusjr commented on code in PR #41260:
URL: https://github.com/apache/airflow/pull/41260#discussion_r1704937003


##########
airflow/models/taskinstance.py:
##########
@@ -3892,9 +3892,17 @@ def schedule_downstream_tasks(self, session: Session = 
NEW_SESSION, max_tis_per_
 
         :meta: private
         """
-        return TaskInstance._schedule_downstream_tasks(
-            ti=self, session=session, max_tis_per_query=max_tis_per_query
-        )
+        try:
+            return TaskInstance._schedule_downstream_tasks(
+                ti=self, session=session, max_tis_per_query=max_tis_per_query
+            )
+        except Exception:
+            self.log.exception(
+                "Error scheduling downstream tasks. Skipping it as this is 
entirely optional optimisation. "
+                "There might be various reasons for it, please take a look at 
the stack trace to figure "
+                "out if the root cause can be diagnosed and fixed. See the 
issue "
+                "https://github.com/apache/airflow/issues/39717 for details 
and example problem."

Review Comment:
   ```suggestion
                   "https://github.com/apache/airflow/issues/39717 for details 
and an example problem."
   ```
   
   It may also be a good idea to tell users what to do after gettting this. 
Just ignore it? (What can I do if it’s noisy?) Post a comment to the issue or 
not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to