jedcunningham commented on code in PR #41186:
URL: https://github.com/apache/airflow/pull/41186#discussion_r1705642762
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -220,6 +220,11 @@ def process_status(
# However, need to free the executor slot from the current
executor.
self.log.info("Event: pod %s adopted, annotations: %s", pod_name,
annotations_string)
self.watcher_queue.put((pod_name, namespace, ADOPTED, annotations,
resource_version))
+ elif hasattr(pod.status, "reason") and pod.status.reason ==
"ProviderFailed":
+ self.log.error("Event: %s ProviderFailed, annotations: %s",
pod_name, annotations_string)
Review Comment:
I think we should be a little more verbose in this error message. Just
`ProviderFailed` isn't intuitive enough imo.
##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -220,6 +220,11 @@ def process_status(
# However, need to free the executor slot from the current
executor.
self.log.info("Event: pod %s adopted, annotations: %s", pod_name,
annotations_string)
self.watcher_queue.put((pod_name, namespace, ADOPTED, annotations,
resource_version))
+ elif hasattr(pod.status, "reason") and pod.status.reason ==
"ProviderFailed":
Review Comment:
Can you add a comment as to how this can happen maybe? It seems to be
specific to Azure. Doesn't have to be a big comment, but something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
