uranusjr commented on code in PR #41302: URL: https://github.com/apache/airflow/pull/41302#discussion_r1706752737
########## airflow/example_dags/example_dataset_alias.py: ########## @@ -22,15 +22,13 @@ Turn on all the DAGs. -Before running any DAG, the schedule of the "dataset-alias-consumer" DAG will show as "Unresolved DatasetAlias". +Before running any DAG, the schedule of the "dataset_alias_example_alias_consumer" DAG will show as "unresolved DatasetAlias". This is expected because the dataset alias has not been resolved into any dataset yet. -Once the "dataset-alias-producer" DAG is triggered, the "dataset-consumer" DAG should be triggered upon completion. +Once the "dataset_s3_bucket_producer" DAG is triggered, the "dataset_s3_bucket_consumer" DAG should be triggered upon completion. This is because the dataset alias "example-alias" is used to add a dataset event to the dataset "s3://bucket/my-task" -during the "produce_dataset_events_through_dataset_alias" task. -As the DAG "dataset-alias-consumer" relies on dataset alias "example-alias" which was previously unresolved, -the DAG "dataset-alias-consumer" (along with all the DAGs in the same file) will be re-parsed and -thus update its schedule to the dataset "s3://bucket/my-task" and will be triggered. +during the "produce_dataset_events_through_dataset_alias" task. Also, the schedule of the "dataset_alias_example_alias_consumer" DAG should change to "Dataset" as +the dataset alias "example-alias" is now resolved to the dataset "s3://bucket/my-task" and this DAG should also be triggered. Review Comment: ```suggestion during the "produce_dataset_events_through_dataset_alias" task. Also, the schedule of the "dataset_alias_example_alias_consumer" DAG should change to "Dataset" as the dataset alias "example-alias" is now resolved to the dataset "s3://bucket/my-task" and this DAG should also be triggered. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
