eladkal commented on code in PR #41122:
URL: https://github.com/apache/airflow/pull/41122#discussion_r1712691279


##########
airflow/providers/airbyte/CHANGELOG.rst:
##########
@@ -26,6 +26,22 @@
 Changelog
 ---------
 
+4.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+.. note::
+  This version introduce a new way to handle the connection to Airbyte using 
``client_id`` and ``client_secret`` instead of ``login`` and ``password``.
+  You can get them accessing the Airbyte UI and creating a new Application in 
the Settings page.
+  You must remove the ``api_type`` parameter from your DAG it isn't required 
anymore.
+  The default scheme is now ``https`` instead of ``http``.
+
+.. Below changes are excluded from the changelog. Move them to
+   appropriate section above if needed. Do not delete the lines(!):
+   * ``Breaking change, update provider to use Airbyte API Python SDK 
(#41122)``

Review Comment:
   ```suggestion
   ```
   
   This is auto generated by release proccess



##########
airflow/providers/airbyte/CHANGELOG.rst:
##########
@@ -26,6 +26,22 @@
 Changelog
 ---------
 
+4.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+.. note::
+  This version introduce a new way to handle the connection to Airbyte using 
``client_id`` and ``client_secret`` instead of ``login`` and ``password``.
+  You can get them accessing the Airbyte UI and creating a new Application in 
the Settings page.
+  You must remove the ``api_type`` parameter from your DAG it isn't required 
anymore.
+  The default scheme is now ``https`` instead of ``http``.
+
+.. Below changes are excluded from the changelog. Move them to
+   appropriate section above if needed. Do not delete the lines(!):
+   * ``Breaking change, update provider to use Airbyte API Python SDK 
(#41122)``

Review Comment:
   ```suggestion
   ```
   
   This is auto generated by release process



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to