uranusjr commented on code in PR #41390:
URL: https://github.com/apache/airflow/pull/41390#discussion_r1713539587
##########
airflow/api/common/delete_dag.py:
##########
@@ -64,18 +64,6 @@ def delete_dag(dag_id: str, keep_records_in_log: bool =
True, session: Session =
if dag is None:
raise DagNotFound(f"Dag id {dag_id} not found")
- # deleting a DAG should also delete all of its subdags
- dags_to_delete_query = session.execute(
- select(DagModel.dag_id).where(
- or_(
- DagModel.dag_id == dag_id,
- and_(DagModel.dag_id.like(f"{dag_id}.%"), DagModel.is_subdag),
- )
- )
- )
-
- dags_to_delete = [dag_id for (dag_id,) in dags_to_delete_query]
Review Comment:
This would fail to actually delete the non-sub DAG (the `== dag_id` part)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
