uranusjr commented on code in PR #41414:
URL: https://github.com/apache/airflow/pull/41414#discussion_r1714863709
##########
airflow/api_internal/endpoints/rpc_api_endpoint.py:
##########
@@ -237,7 +237,8 @@ def internal_airflow_api(body: dict[str, Any]) ->
APIResponse:
response = json.dumps(output_json) if output_json is not None else
None
log.info("Sending response: %s", response)
return Response(response=response, headers={"Content-Type":
"application/json"})
- except AirflowException as e: # In case of AirflowException transport the
exception class back to caller
+ # In case of AirflowException or other selective known types, transport
the exception class back to caller
+ except (KeyError, AttributeError, AirflowException) as e:
Review Comment:
What’s the criteria here? Why not include say ValueError or TypeError? (I’m
just listing random names, not concrete suggestions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
