(airflow) branch main updated: Fix news fragment check conditional (#41491)

[jedcunningham]

This is an automated email from the ASF dual-hosted git repository.

jedcunningham pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 97ff31d380 Fix news fragment check conditional (#41491)
97ff31d380 is described below

commit 97ff31d3801483722e1ce05fbad77b6e322fb00d
Author: Tzu-ping Chung <uranu...@gmail.com>
AuthorDate: Thu Aug 15 11:29:15 2024 +0800

    Fix news fragment check conditional (#41491)
    
    We only want to fail the script if the 'towncrier check' call fails. The
    previous code always runs the '&& false' part (because the printf call
    always succeeds) and failed the job.
---
 .github/workflows/news-fragment.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/news-fragment.yml 
b/.github/workflows/news-fragment.yml
index 1e6d4279f5..6691bf65f9 100644
--- a/.github/workflows/news-fragment.yml
+++ b/.github/workflows/news-fragment.yml
@@ -43,9 +43,11 @@ jobs:
           --config newsfragments/config.toml
           --compare-with origin/${{ github.base_ref }}
           ||
+          {
           printf "\033[1;33mMissing significant newsfragment for PR labeled 
with
           'airflow3.0:breaking'.\nCheck
           
https://github.com/apache/airflow/blob/main/contributing-docs/16_contribution_workflow.rst
           for guidance.\033[m\n"
           &&
           false
+          ; }