howardyoo opened a new pull request, #41502:
URL: https://github.com/apache/airflow/pull/41502
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR fixes the issue of try_number being incorrectly decremented in
certain occasions when instrumenting and emitting span and span attributes for
the task instance. try_number needed to be decremented or incremented in
Airflow, depending on conditions and logic, but has been resolved in the PR:
https://github.com/apache/airflow/pull/39336, and will be available in Airflow
2.10.0. Due to this fix, it is necessary for the parts where try_number was
being decremented to not continue to do so for the OTEL span instrumentation.
closes #41501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
