topherinternational commented on issue #21004: URL: https://github.com/apache/airflow/issues/21004#issuecomment-2294614693
@uranusjr @potiuk I took a look at this as a good-first-issue, and I think there's a PMC-level question to be answered before I want to start writing any code. The `CloudantHook` returns a `cloudant` object from the now-discontinued `cloudant` library, a context manager object that yields a logged-in client session object (of type `Cloudant`, with a capital C). `ibmcloudant` is the replacement for `cloudant`, but it discontinues the context manager patterns, and its client object also has a different set of functions that can be called against the Cloudant server. The mapping of `cloudant` calls to `ibmcloudant` calls can be found here: https://github.com/cloudant/python-cloudant/blob/master/MIGRATION.md#reference-table; you can see that calls have changed names and been moved across objects/interfaces. So my question is, if `cloudant` were swapped out for `ibmcloudant`, how should we handle the breaking change? Is it enough to bump the cloudant provider version to 4.x.x, or does this need to break across Airflow 2->3 or 3->4? Thanks for any insight you can provide, It's hard to proceed intelligently not knowing the provider breaking change policy nor understanding at all how users might be using this hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
