kacpermuda opened a new pull request, #41587:
URL: https://github.com/apache/airflow/pull/41587
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Even after fix in #41494 has been implemented, we were still able to cause
the scheduler OOM error when creating a dag_tree with the example dag below:
<details>
<summary>dag crashing the dagTree</summary>
```
with DAG("dag", schedule=None):
start = EmptyOperator(task_id="start")
a = [
start
>> EmptyOperator(task_id=f"a_1_{i}")
>> EmptyOperator(task_id=f"a_2_{i}")
>> EmptyOperator(task_id=f"a_3_{i}")
for i in range(200)
]
middle = EmptyOperator(task_id="middle")
b = [
middle
>> EmptyOperator(task_id=f"b_1_{i}")
>> EmptyOperator(task_id=f"b_2_{i}")
>> EmptyOperator(task_id=f"b_3_{i}")
for i in range(200)
]
middle2 = EmptyOperator(task_id="middle2")
c = [
middle2
>> EmptyOperator(task_id=f"c_1_{i}")
>> EmptyOperator(task_id=f"c_2_{i}")
>> EmptyOperator(task_id=f"c_3_{i}")
for i in range(200)
]
end = EmptyOperator(task_id="end")
start >> a >> middle >> b >> middle2 >> c >> end
```
</details>
To prevent OpenLineage from breaking the scheduler with additional
computation, we should only rely on the information that Airflow uses itself -
downstream task ids.
This PR removes the dagTree information from OL AirflowJobFacet and adds
downstream task ids to the list of tasks included in the same facet. This
dramatically reduces the size of the facet and allows the consumer that rely on
this information to sill re-create it.
<details>
<summary>example snippet to re-create</summary>
```
tasks = {
'task': {'downstream_tasks': []},
'task1': {'downstream_tasks': ["task"]},
'task2': {'downstream_tasks': ["task1"]},
}
def add_to_tree(task_id, tree):
if task_id not in tree:
tree[task_id] = {}
for downstream_task in tasks[task_id].get('downstream_tasks', []):
add_to_tree(downstream_task, tree[task_id])
def is_root_task(task_id):
# A task is considered a root task if no other task lists it as a
downstream task
for task_info in tasks.values():
if task_id in task_info.get('downstream_tasks', []):
return False
return True
dag_tree = {}
for task_id in tasks:
if is_root_task(task_id):
add_to_tree(task_id, dag_tree)
print(dag_tree)
# {'task2': {'task1': {'task': {}}}}
```
</details>
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
