uranusjr commented on code in PR #41307:
URL: https://github.com/apache/airflow/pull/41307#discussion_r1722839752
##########
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##########
@@ -378,11 +386,15 @@ def get_task_instances(
)
.add_columns(SlaMiss)
.options(joinedload(TI.rendered_task_instance_fields))
- .offset(offset)
- .limit(limit)
)
+
+ order_by_params = _get_order_by_params(order_by or "start_date")
Review Comment:
This default should be mentioned somewhere. I’m not sure this is a good
default though? I’d probably expect this to be ordered naturally (the current
behaviour in main), or by `(dag_id, dag_run_id, task_id, map_idnex)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
