uranusjr commented on code in PR #41316:
URL: https://github.com/apache/airflow/pull/41316#discussion_r1723017586


##########
airflow/utils/operator_helpers.py:
##########
@@ -163,6 +163,13 @@ def determine(
         has_wildcard_kwargs = any(p.kind == p.VAR_KEYWORD for p in 
signature.parameters.values())
 
         for name in itertools.islice(signature.parameters.keys(), len(args)):
+            if signature.parameters[name].kind in [
+                inspect.Parameter.KEYWORD_ONLY,
+                inspect.Parameter.VAR_KEYWORD,
+            ]:
+                # this is only checking positional arguments
+                continue

Review Comment:
   ```suggestion
           for name, param in itertools.islice(signature.parameters.items(), 
len(args)):
               # Keyword-only arguments can't be passed positionally and are 
not checked.
               if param.kind == inspect.Parameter.KEYWORD_ONLY:
                   continue
               if param.kind == inspect.Parameter.VAR_KEYWORD:
                   continue
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to