phi-friday commented on code in PR #41592:
URL: https://github.com/apache/airflow/pull/41592#discussion_r1723158241
##########
airflow/decorators/base.py:
##########
@@ -431,18 +431,29 @@ def _expand(self, expand_input: ExpandInput, *, strict:
bool) -> XComArg:
dag = task_kwargs.pop("dag", None) or DagContext.get_current_dag()
task_group = task_kwargs.pop("task_group", None) or
TaskGroupContext.get_current_task_group(dag)
- partial_kwargs, partial_params = get_merged_defaults(
+ default_args, partial_params = get_merged_defaults(
dag=dag,
task_group=task_group,
task_params=task_kwargs.pop("params", None),
task_default_args=task_kwargs.pop("default_args", None),
)
- partial_kwargs.update(
- task_kwargs,
- is_setup=self.is_setup,
- is_teardown=self.is_teardown,
- on_failure_fail_dagrun=self.on_failure_fail_dagrun,
- )
+ partial_kwargs: dict[str, Any] = {
+ "is_setup": self.is_setup,
+ "is_teardown": self.is_teardown,
+ "on_failure_fail_dagrun": self.on_failure_fail_dagrun,
+ }
+ base_signature = inspect.signature(BaseOperator)
+ ignore = {
+ "default_args",
+ "kwargs",
+ "do_xcom_push",
+ "multiple_outputs",
+ "params",
+ "task_concurrency",
+ }
Review Comment:
I'm still not quite sure about `do_xcom_push`, so if you can tell me what
comments I should add to that, I'll add them to the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
