potiuk commented on code in PR #40421:
URL: https://github.com/apache/airflow/pull/40421#discussion_r1724759794
##########
airflow/www/views.py:
##########
@@ -4359,10 +4359,7 @@ def process_form(self, form, is_created):
conn_type_from_extra_field = key.split("__")[1]
if conn_type_from_extra_field == conn_type:
value = form.data[key]
- # Some extra fields have a default value of False so we
need to explicitly check the
- # value isn't an empty string.
- if value != "":
- extra[field_name] = value
+ extra[field_name] = value
Review Comment:
Might be, I am still not sure what exactly scenario was described in
https://github.com/apache/airflow/pull/23241 - but maybe (again) @dstandish and
@josh-fell can shed some light on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
