uranusjr commented on code in PR #41591:
URL: https://github.com/apache/airflow/pull/41591#discussion_r1727117345
##########
tests/models/test_taskinstance.py:
##########
@@ -3421,14 +3422,27 @@ def on_execute_callable(context):
ti.refresh_from_db()
assert ti.state == State.SUCCESS
- def test_finished_callbacks_handle_and_log_exception(self, caplog):
+ def test_finished_callbacks_callables_handle_and_log_exception(self,
caplog):
+ def on_finish_callable(context):
+ pass
+
+ for callback_input in [[on_finish_callable, on_finish_callable],
on_finish_callable]:
Review Comment:
Let’s use `pytest.mark.parametrize` instead of a for loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]