vincbeck commented on code in PR #41671:
URL: https://github.com/apache/airflow/pull/41671#discussion_r1727141481
##########
airflow/config_templates/config.yml:
##########
@@ -477,15 +477,15 @@ core:
type: string
default: "0o077"
example: ~
- dataset_manager_class:
Review Comment:
These were not deprecated. I think the plan is to add deprecation warning
for whatever we are removing/renaming in 2.11. What is the plan here? Should we
add them now in 2.10 branch? Or wait December to add them (then we need to keep
track of all breaking changes, through significant files maybe?) @potiuk
@eladkal
##########
airflow/providers/openlineage/utils/utils.py:
##########
@@ -31,9 +31,9 @@
from packaging.version import Version
from airflow import __version__ as AIRFLOW_VERSION
-from airflow.datasets import Dataset
from airflow.exceptions import AirflowProviderDeprecationWarning # TODO: move
this maybe to Airflow's logic?
from airflow.models import DAG, BaseOperator, MappedOperator
+from airflow.providers.common.compat.assets import Dataset
Review Comment:
That makes this provider at the current version unusable with Airflow 3,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
