LipuFei commented on PR #41524: URL: https://github.com/apache/airflow/pull/41524#issuecomment-2306476685
> We have a ton of conditionals like [if CeleryExecutor](https://github.com/apache/airflow/blob/09ce3a5100c266369350c85e9f9a0f72ecca9e98/chart/templates/workers/worker-deployment.yaml#L26) so we can provision the right stuff for the release, but you've not accounted for any of that with this change. Try it with `CeleryExecutor,KubernetesExecutor`, for example, to see the problems this brings. > > I think @hussein-awala idea of an array of executors makes sense, but I agree the shortname/enum thing is definitely a problem. We will need to come up with something here. I agree. After some digging, I indeed see a lot of references to `.Values.executor` everywhere, not to mention the `executor` references to `.Values.config.core.executor` and they need to be the same... I will work on this slowly, excluding the short name support. It's a lot more complex than I initially expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
