konqui0 commented on code in PR #6767:
URL: https://github.com/apache/airflow/pull/6767#discussion_r356894253


##########
airflow/utils/log/logging_mixin.py:
##########
@@ -116,6 +116,13 @@ def isatty(self):
         """
         return False
 
+    def fileno(self):
+        """
+        Returns the stdout file descriptor 1.
+        For compatibility reasons e.g python subprocess module stdout 
redirection.
+        """
+        return 1

Review Comment:
   Is there a way to identify if the stream is stderr within the 
StreamLogWriter?
   
   That's true, the only alternative I can think of would be creating a pipe, 
returning its fd and writing everything written to that pipe.
   
   I'm not sure if this would be an acceptable solution / workaround. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to