raphaelauv commented on code in PR #41727:
URL: https://github.com/apache/airflow/pull/41727#discussion_r1730855155
##########
airflow/sensors/time_delta.py:
##########
@@ -80,12 +79,8 @@ def execute(self, context: Context) -> bool | NoReturn:
if timezone.utcnow() > target_dttm:
# If the target datetime is in the past, return immediately
return True
- try:
- trigger = DateTimeTrigger(moment=target_dttm,
end_from_trigger=self.end_from_trigger)
- except (TypeError, ValueError) as e:
- if self.soft_fail:
- raise AirflowSkipException("Skipping due to soft_fail is set
to True.") from e
- raise
+
+ trigger = DateTimeTrigger(moment=target_dttm,
end_from_trigger=self.end_from_trigger)
Review Comment:
my bad I did not saw that `TimeDeltaSensorAsync` was not using `poke` but
directly `execute` ( do you know why ? )
so yes this operator is not using the soft_fail logic of the
BaseSensorOperator
I just did a revert PR -> https://github.com/apache/airflow/pull/41741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
