This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new c5a7fb11a7 Remove deprecations in airflow.models.errors (#41779)
c5a7fb11a7 is described below
commit c5a7fb11a795efb777f1f63ff13d67f9d84e1250
Author: Jens Scheffler <[email protected]>
AuthorDate: Tue Aug 27 14:34:40 2024 +0200
Remove deprecations in airflow.models.errors (#41779)
* Remove deprecations in airflow.models.errors
* Fix static code checks in compat
---
airflow/models/errors.py | 17 -----------------
newsfragments/41779.significant.rst | 1 +
tests/test_utils/compat.py | 2 +-
3 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/airflow/models/errors.py b/airflow/models/errors.py
index f891b03d67..403b0cd018 100644
--- a/airflow/models/errors.py
+++ b/airflow/models/errors.py
@@ -17,11 +17,8 @@
# under the License.
from __future__ import annotations
-import warnings
-
from sqlalchemy import Column, Integer, String, Text
-from airflow.exceptions import RemovedInAirflow3Warning
from airflow.models.base import Base
from airflow.utils.sqlalchemy import UtcDateTime
@@ -35,17 +32,3 @@ class ParseImportError(Base):
filename = Column(String(1024))
stacktrace = Column(Text)
processor_subdir = Column(String(2000), nullable=True)
-
-
-def __getattr__(name: str):
- # PEP-562: Lazy loaded attributes on python modules
- if name == "ImportError":
- warnings.warn(
- f"Model class '{__name__}.ImportError' is deprecated due to
shadowing with builtin exception "
- f"ImportError and will be removed in the future. "
- f"Please consider to use '{__name__}.ParseImportError' instead.",
- RemovedInAirflow3Warning,
- stacklevel=2,
- )
- return ParseImportError
- raise AttributeError(f"module {__name__} has no attribute {name}")
diff --git a/newsfragments/41779.significant.rst
b/newsfragments/41779.significant.rst
new file mode 100644
index 0000000000..f25e0c9080
--- /dev/null
+++ b/newsfragments/41779.significant.rst
@@ -0,0 +1 @@
+Remove deprecated support for ``airflow.models.errors.ImportError`` which has
been renamed to ``ParseImportError``.
diff --git a/tests/test_utils/compat.py b/tests/test_utils/compat.py
index b5e876a626..b09973903b 100644
--- a/tests/test_utils/compat.py
+++ b/tests/test_utils/compat.py
@@ -36,7 +36,7 @@ try:
# all providers are updated to airflow 2.10+.
from airflow.models.errors import ParseImportError
except ImportError:
- from airflow.models.errors import ImportError as ParseImportError # type:
ignore[no-redef]
+ from airflow.models.errors import ImportError as ParseImportError # type:
ignore[no-redef,attr-defined]
from airflow import __version__ as airflow_version
