Nikolas Vanderhoof created AIRFLOW-5460:
-------------------------------------------

             Summary: Why does airlfow allow multiple connections with the same 
connection id?
                 Key: AIRFLOW-5460
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5460
             Project: Apache Airflow
          Issue Type: Bug
          Components: core
    Affects Versions: 1.10.5
            Reporter: Nikolas Vanderhoof


I tagged the issue as a Bug, but it's probably a feature that I just don't 
understand the reasoning behind. 

I was working on creating a custom hook in airflow. I would expect that 
get_connection from BaseHook would return deterministically. To my surprise, it 
returns a randomly chosen connection from all connections with the given 
connection id. 

My gut reaction to this: it seems like a bad design choice to allow users to 
specify multiple connections with the same id. If there is a compelling reason 
for allowing this, I would like to understand it, and at least broadcast that 
connections can share ids in the documentation so other users are not as 
surprised by the feature. 

Not sure who to tag on this, please forgive any mis-tagging here. :)
[~maxime.beauche...@apache.org] [~kaxilnaik] [~higrys] [~ash] [~Fokko]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to