potiuk commented on PR #41846:
URL: https://github.com/apache/airflow/pull/41846#issuecomment-2317731029
Looks good @bbovenzi - I saw you changed www compilation to happen in
foreground to fix running two background pre-commits at the same time - that
should do at the expense of slower startup time when www change but that should
be rare if at all now).
Few coments on failing tests:
* All failing selective check tests - there is no need to add UI to
SelectiveUnitTtestType at all - there are no "python" tests in "tests/ui" -
those unit tests are python -only - WWW "javascript" tests are run separately
(React WWW). Those "WWW" tests are python tests for "airflow/www/*.py` files.
This is the reason why the UI tests are "hanging"
As I understand Python code is still going to be in "airflow/www" ? If yes -
just re
If want to have some python tests in "tests/ui" - the `"UI": ["tests/ui"]`
entry should be added to this map (in `airflow_breeze/utils/run_tests.py` -
where type of test is mapped to the pytest command executed (and some "empty"
test should be added in "tests/ui"):
```python
TEST_TYPE_MAP_TO_PYTEST_ARGS: dict[str, list[str]] = {
...
"WWW": [
"tests/www",
],
}
```
* React UI tests failing - `pnpm` needs to be installed after "setup-node"
step - as we are running the tests without Breeze CI image
* Test Open API Client - should be already fixed in main by #41858
* Static checks - just re-basing + re-running pre-commit should fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
