tirkarthi opened a new pull request, #41905: URL: https://github.com/apache/airflow/pull/41905
Thanks @bbovenzi for the new UI page and contribution docs. Looks really nice with built in dark mode from ground up. New build system using Vite and HMR is really nice. I don't need to reload for changes and enables a faster feedback loop with state intact. I tried implementing basic pagination for the new UI page. I opened this PR for initial feedback and some questions on trying out the implementation in new UI. I guess it serves as a good point to discuss and improve upon. Questions 1. In the previous API the case of the keys of the response used to be changed using interceptor. In this case will this be applicable to new API/UI? like total_entries will become totalEntries? 2. Default dags per page is configurable in airflow.cfg . Earlier the values used to be passed along meta tag for rendering. In this case page title and page size are some of the attributes that might be needed. I don't see any endpoint in airflow/www/views.py so I was wondering how to get those values here like the other react implementation. Currently, I just used 10 hard coded as a constant. 3. The new UI generates API stubs from openapi I guess similar to the other react project. Will this be merged eventually as I see useQuery for other parts with somewhat different conventions compared to the current one where useDagServiceGetDags is used. Pagination Ref : https://tanstack.com/table/latest/docs/guide/pagination#manual-server-side-pagination https://medium.com/@aylo.srd/server-side-pagination-and-sorting-with-tanstack-table-and-react-bd493170125e Screenshot : (first page, previous page, next page, last page)  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
