dstandish commented on code in PR #41904:
URL: https://github.com/apache/airflow/pull/41904#discussion_r1739384120
##########
airflow/providers/celery/executors/celery_kubernetes_executor.py:
##########
@@ -71,11 +75,21 @@ def kubernetes_queue(self) -> str:
def __init__(self, celery_executor: CeleryExecutor, kubernetes_executor:
KubernetesExecutor):
super().__init__()
- self._job_id: int | None = None
+ self._job_id: int | str | None = None
self.celery_executor = celery_executor
self.kubernetes_executor = kubernetes_executor
self.kubernetes_executor.kubernetes_queue = self.kubernetes_queue
+ @property
+ def _task_event_logs(self):
+ self.celery_executor._task_event_logs +=
self.kubernetes_executor._task_event_logs
Review Comment:
we're appending to the celery queue and returning it. essentially, what
this does is merge the queues every time it's accessed. the only time this is
accessed is when the schedule is consuming the queue.
##########
airflow/providers/celery/executors/celery_kubernetes_executor.py:
##########
@@ -71,11 +75,21 @@ def kubernetes_queue(self) -> str:
def __init__(self, celery_executor: CeleryExecutor, kubernetes_executor:
KubernetesExecutor):
super().__init__()
- self._job_id: int | None = None
+ self._job_id: int | str | None = None
self.celery_executor = celery_executor
self.kubernetes_executor = kubernetes_executor
self.kubernetes_executor.kubernetes_queue = self.kubernetes_queue
+ @property
+ def _task_event_logs(self):
+ self.celery_executor._task_event_logs +=
self.kubernetes_executor._task_event_logs
+ self.kubernetes_executor._task_event_logs.clear()
Review Comment:
right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
