bugraoz93 commented on code in PR #59: URL: https://github.com/apache/airflow-ci-infra/pull/59#discussion_r1739452776
########## runner/Dockerfile: ########## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +FROM ghcr.io/actions/actions-runner:latest + +USER root + +RUN apt-get update \ + && apt-get install -y --no-install-recommends \ + ca-certificates curl nodejs npm wget unzip vim git jq build-essential netcat \ Review Comment: The changes look good to me! I skimmed through all the CI jobs and their scripts to ease your job. The CI jobs have steps for installing their dependencies very well. Other than some commands like `curl`, `git`, `netcat` etc. This addition should be enough. I am not sure if we need `wget` though because please correct me if I am wrong but I haven't seen any usage from `wget` other than in a couple of Dockerfiles which should install by itself. Maybe, we shouldn't install it here to not deal with its vulnerabilities. Of course, it's always good to double-check. I hope it helps! ```suggestion ca-certificates curl nodejs npm wget unzip vim git jq build-essential netcat openssh-client \ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
