potiuk commented on code in PR #41690:
URL: https://github.com/apache/airflow/pull/41690#discussion_r1740718887


##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -336,33 +335,36 @@ def fail_task(
 
     def dag_started(
         self,
-        dag_run: DagRun,
-        msg: str,
+        dag_id: str,
+        execution_date: datetime,

Review Comment:
   Yeah. I know it's there - same as in #41889  - the question is whether it 
will not change semantics of the produced openlineage events because 
`execution_date` and `logical_date` are not 1-1. 
   
   So - I am not against it, but the question is whether **some** explanation 
in changelog should be given to the users when we do the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to