gopidesupavan commented on code in PR #41848:
URL: https://github.com/apache/airflow/pull/41848#discussion_r1745337228
##########
airflow/providers/amazon/aws/triggers/glue_databrew.py:
##########
@@ -27,20 +30,38 @@ class GlueDataBrewJobCompleteTrigger(AwsBaseWaiterTrigger):
:param job_name: Glue DataBrew job name
:param run_id: the ID of the specific run to watch for that job
- :param delay: Number of seconds to wait between two checks. Default is 10
seconds.
- :param max_attempts: Maximum number of attempts to wait for the job to
complete. Default is 60 attempts.
+ :param delay: Number of seconds to wait between two checks.(Deprecated).
+ :param waiter_delay: Number of seconds to wait between two checks. Default
is 30 seconds.
+ :param max_attempts: Maximum number of attempts to wait for the job to
complete.(Deprecated).
+ :param waiter_max_attempts: Maximum number of attempts to wait for the job
to complete. Default is 60 attempts.
:param aws_conn_id: The Airflow connection used for AWS credentials.
"""
def __init__(
self,
job_name: str,
run_id: str,
- aws_conn_id: str | None,
- delay: int = 10,
- max_attempts: int = 60,
+ delay: int | None = None,
+ max_attempts: int | None = None,
+ waiter_delay: int = 30,
+ waiter_max_attempts: int = 60,
+ aws_conn_id: str | None = "aws_default",
**kwargs,
):
+ if delay is not None:
+ warnings.warn(
+ "please use waiter_delay instead of delay.",
Review Comment:
updated thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
