topherinternational commented on code in PR #41555:
URL: https://github.com/apache/airflow/pull/41555#discussion_r1745543361
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -1278,7 +1277,10 @@ def excluded_providers_as_string(self) -> str:
if "excluded-python-versions" in provider_info:
for python_version in
provider_info["excluded-python-versions"]:
providers_to_exclude[python_version].append(provider)
- return json.dumps(providers_to_exclude)
+ sorted_providers_to_exclude = dict(
+ sorted(providers_to_exclude.items(), key=lambda item:
int(item[0].split(".")[1]))
Review Comment:
Python makes this more complicated than it could be but I figured this
dictionary should be sorted by Python version, esp since our test for this is a
string equivalency and not just `dict == dict`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
