jedcunningham commented on code in PR #42019:
URL: https://github.com/apache/airflow/pull/42019#discussion_r1745689679
##########
airflow/api_ui/app.py:
##########
@@ -32,17 +38,35 @@ def init_dag_bag(app: FastAPI) -> None:
app.state.dag_bag = get_dag_bag()
-def create_app() -> FastAPI:
+def init_flask_app(app: FastAPI, testing: bool = False) -> None:
+ """
+ Auth providers and permission logic are tightly coupled to Flask.
Review Comment:
There is definitely going to have to be some decoupling/refactoring anyways.
For example, [auth managers expect an appbuilder
today](https://github.com/apache/airflow/blob/12bb8b35241f0915e82a322c7905c8602df95a7f/airflow/auth/managers/base_auth_manager.py#L72),
and it's already on my "must change" list for AIP-79 :)
But yes, FAB / our security manager / auth managers, it's all pretty
intertwined and messy today. I believe we can solve it in 3, but in the
meantime I think initing like this is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
