pierrejeambrun commented on code in PR #42019:
URL: https://github.com/apache/airflow/pull/42019#discussion_r1746933916
##########
airflow/api_ui/app.py:
##########
@@ -32,17 +38,35 @@ def init_dag_bag(app: FastAPI) -> None:
app.state.dag_bag = get_dag_bag()
-def create_app() -> FastAPI:
+def init_flask_app(app: FastAPI, testing: bool = False) -> None:
+ """
+ Auth providers and permission logic are tightly coupled to Flask.
Review Comment:
> I have another proposal. Why do you want to have basic authentication for
this API?
Because the basic auth is the easier to modify and make compatible with
FastAPI. Also FastAPI session implementation has some security implications +
requires extra packages and configuration. So I thought at first I would make
the basic auth work and these can be follow up / improvements. Cf this FastAPI
issue:
https://github.com/fastapi/fastapi/issues/754
The UI can work with basic auth for development time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
