topherinternational commented on PR #42066:
URL: https://github.com/apache/airflow/pull/42066#issuecomment-2334489099
> I’ve re-applied the previous changes here, and also added a fix so callers
(including HookLineageCollector) can continue to pass in a None. It will be
converted automatically to a dict.
>
> Can you work on a test to cover the `dataset_factory` code path?
I removed my original change, I think it's best if we keep the call stack as
it is and use your fix that coerces the None to {} only in the Dataset
constructor, less confusing and easier to test that way imo.
I added more tests to create_dataset that cover the dataset_factory API
(uri, kwargs, missing factory, and factory exception are covered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
