MaksYermak commented on code in PR #42080:
URL: https://github.com/apache/airflow/pull/42080#discussion_r1749993868
##########
airflow/providers/google/cloud/triggers/pubsub.py:
##########
@@ -106,7 +106,10 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
):
if self.ack_messages:
await self.message_acknowledgement(pulled_messages)
- yield TriggerEvent({"status": "success", "message":
pulled_messages})
+
+ messages_json = [ReceivedMessage.to_dict(m) for m in
pulled_messages]
Review Comment:
@gopidesupavan I see the reason why we need this conversion, but could you
please move this code in `execute_complete` here:
https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/sensors/pubsub.py#L176
?
In my opinion `execute_complete` is the better place to do this conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]